Codecov Report

❌ Patch coverage is 8.77193% with 52 lines in your changes missing coverage. Please review.
✅ Project coverage is 69.30%. Comparing base (ce1b405) to head (f9fba52).
⚠️ Report is 230 commits behind head on trunk.

@@            Coverage Diff             @@
##            trunk    #2321      +/-   ##
==========================================
+ Coverage   68.85%   69.30%   +0.45%     
==========================================
  Files          90       90              
  Lines        7612     7763     +151     
==========================================
+ Hits         5241     5380     +139     
- Misses       2371     2383      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment from @sarthak-19 in Slack:

I raised a draft PR because currently I was unsure of what more are we expecting to be delivered in this task for polishing, since the issue mentioned of Add support for customizing transition animation duration
But this was already added in the UI as well.
What I did for potential polishing items are :

1. Added validation bounds - Duration is now clamped between 100ms and 5000ms with proper input validation
2. Applied duration to admin - Admin view transitions now also respect the duration setting
3. Added real-time preview - The seconds equivalent updates dynamically as you type in the > milliseconds field.
4. Exposed in REST API - Added default_transition_animation_duration to the REST API schema
5. Added unit tests - Tests for duration sanitization, clamping, and the injection function

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @sarthak.jaiswal@rtCamp.com.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Unlinked contributors: sarthak.jaiswal@rtCamp.com.

Co-authored-by: adamsilverstein <adamsilverstein@git.wordpress.org>
Co-authored-by: westonruter <westonruter@git.wordpress.org>
Co-authored-by: sarthak-19 <sarthak8858@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Another polishing idea: there could be validation added to the input fields for the CSS selectors. Maybe this would be as simple as a pattern attribute added to each with a regex that would roughly match a valid regex. A more sophisticated validation would be to use JS to put the selector into a call to document.querySelector. If it errors, then we'd know the selector is invalid and we could call setCustomValidity() on the input element. I don't think there would be any security issue introduced by running user input into a JS function like that.

@westonruter I'm not able to figure out why unit test is failing for PHP 8.3+.
Ref job : https://github.com/WordPress/performance/actions/runs/21336924141/job/61410218740?pr=2321
In my local wp-env I'm testing on PHP 8.3, it's passing.

Running as single site... To run multisite, use -c tests/phpunit/multisite.xml
Not running ajax tests. To execute these, use --group ajax.
Not running ms-files tests. To execute these, use --group ms-files.
Not running external-http tests. To execute these, use --group external-http.
PHPUnit 8.5.42 by Sebastian Bergmann and contributors.

Runtime:       PHP 8.3.30
Time: 798 ms, Memory: 42.50 MB

OK (18 tests, 39 assertions)
✔ Ran `composer test:view-transitions` in 'tests-cli'. (in 2s 284ms)

Any ideas ?